Padlock icons still sneaking into the distribution

OK…just installed 4.3.

I STILL see Padlock icons for dispvms at certain sizes. (If I put a shortcut in a quick launcher, the icon will change form from the correct two qubes to padlock and back again as I resize the launcher.)

I have finally figured out why.

qubes icons are generally stored in /usr/share/icons/hicolor/NNxNN/devices/dispvm-purple.svg (to use purple as an example) where NN is the size (various numbers between 16 and 512).

However there is one old directory /usr/share/icons/hicolor/48x48/apps/dispvm-purple.svg (apps, not devices) and apparently the icon renderer grabs that when the icons are the right size, not ..../devices/dispvm-purple.svg.

The dispvm icons in that directory are padlocks.

First question: Is this padlock style intentional in apps? If so the icon renderer needs to ignore it.

Second question: Can this directory simply be deleted (and can we delete it from the code base, like have the next update remove it)?

There is also /usr/share/qubes/icons/dispvm* which is also a bunch of padlocks. It’s a different path; if for some reason it needs to be there can we stock it with the proper icons?

I don’t have a github account; if any of what I am saying makes sense can someone submit the request?

Manually copied this from here:

More likely, it is tricky to hunt down the source… or the right people, with the necessary skillset(s), do not read every message here.

Do your padlocks look like this one:

source of ancient padlock ?

There is an issue which sounds like the same icon, appearing in a different place:
Padlock icon present when a non-service disposable sends a notification via notification proxy #10279

Do your padlocky icons appear when you make a desktop shortcut. I can’t see any in my qube Settings/Applications - what is the shortcut you create, and how do you do it ? I didn’t yet find how to reproduce it.

It looks a bit like there are two sources of ‘dispvm-green.png’ - searching for likely files by searching the repo in a fedora qube:
sudo dnf provides "*/dispvm-green.png"

The pretty ones come from qubes-artwork (maybe these added in commit #53 ) . There are also the SVG files, which are in a “scalable” directory of the same repo.

The strange one I linked above comes from olden times, in the repo qubes-desktop-linux-common at the same link as above: qubes-desktop-linux-common/icons/dispvm-green.png at main · QubesOS/qubes-desktop-linux-common · GitHub

That is all very good - IF it is as I am supposing, but how to both be sure we diagnosed it right, and then make it easy for someone to fix. It is beyond my zone… I’m just fumbling about, and definitely not one of those “right people”!!!

Maybe it only needs a little issue, and then for a suitably competent person to do a whole load of working out whether those ones in qubes-desktop-linux-common are needed for fallback purposes…

Edit to add: In dom0, I can find a single reference to the /usr/share/qubes/icons directory, which contains some other padlock icons, with no “arrow swirl”. It is in the python for qubesadmin tests:
/usr/lib/python3.13/site-packages/qubesadmin/tests/backup/backupcompatibility.py

I just realised: I do have the /usr/share/icons/hicolor/48x48/apps/dispvm-purple.svg file, but only in dom0. Like I said - I’m out of my depth!

A simple method to reproduce might help…

I know where the errant padlock files are–I gave that info in my original post. It’s an odd-one-out subdirectory that gets referenced (instead of the directory with the cubes/qubes) at a certain icon size.

You are right to point out that it seems to be dom0 only; I wasn’t even thinking about that distinction.

I used purple as an example but all of the colors have this issue.

I found out they were still here when i set up quicklauncher widgets in KDE. In essence a quick launcher is a box that holds icons; I create one for each VM. I just click on the icons and whatever I click on runs in that VM. I usually put a “Start VM” icon in there, and that’s the one that displays the padlock, but only for certain sizes. The quicklauncher will expand or shrink the icons within it to fit.

I have no idea what a comparable thing would be in the default xfce desktop; any situation where you can show the icons and their size can change…at somewhere roughly 40x40 pixels you’ll suddenly see the padlock instead of the double-cube icon.

Basically I have identified where the errant files are; I just want someone to go into the distribution and replace or delete them.