OK…just installed 4.3.
I STILL see Padlock icons for dispvms at certain sizes. (If I put a shortcut in a quick launcher, the icon will change form from the correct two qubes to padlock and back again as I resize the launcher.)
I have finally figured out why.
qubes icons are generally stored in /usr/share/icons/hicolor/NNxNN/devices/dispvm-purple.svg (to use purple as an example) where NN is the size (various numbers between 16 and 512).
However there is one old directory /usr/share/icons/hicolor/48x48/apps/dispvm-purple.svg (apps, not devices) and apparently the icon renderer grabs that when the icons are the right size, not ..../devices/dispvm-purple.svg.
The dispvm icons in that directory are padlocks.
First question: Is this padlock style intentional in apps? If so the icon renderer needs to ignore it.
Second question: Can this directory simply be deleted (and can we delete it from the code base, like have the next update remove it)?
There is also /usr/share/qubes/icons/dispvm* which is also a bunch of padlocks. It’s a different path; if for some reason it needs to be there can we stock it with the proper icons?
I don’t have a github account; if any of what I am saying makes sense can someone submit the request?