-
Older hardware generally suits Qubes OS better. If you run Qubes OS on too new PC, many problems may occur.
-
If you have ever felt uncomfortable with small memory size, get a bigger one. I assume that you know when your Qubes OS is short of memory.
-
It all depends on how you are using the storage. A student major in CS that keeps compiling different versions of linux kernel and plays with docker containers uses up storage way faster than a normal user who is browsing internet and using libreoffice for daily work.
Anyway, considering that your memory is DDR4, I would suggest old hardware - just boost your memory up to 32GB or 64GB (boost your memory if you ever felt short of memory) and that should help a great deal. Aside from that, a new machine improve quality of life only if your brand new CPU cost less electricity; however:
(1) new Intel CPU support S3 sleep poorly, so if you are user of “suspend” then think twice before choosing very new Intel CPU;
(2) new hardware brings new hardware issues; it takes at least around 2 years to make Qubes OS support one set of new hardware well.