Why differences between images and pdfs sanitisation implementation?

General Discussion
1

Hello there,

I frequently sanitise many pdfs using qvm-convert-pdf file1.pdf file2.pdf or qvm-convert-pdf *.pdf.
I tried to do the same with qvm-convert-img; it did not work, and made me read the man page for it. Realising its content was vastly different from qvm-convert-pdf’s one, I looked at the source code, and here again, found clear differences – not relative to design, but technical details (not the same python modules used, not the same repository structure, etc.).

I’m kinda surprised, as I would have tought that those commands would share a common implementation. Is there a particular reason for this?

I’m asking this because I believe qvm-convert-img should work like qvm-convert-pdf, so I was considering trying to implement it myself, and then, if it reveals to be successful, submit a pull request.

2 Likes
2

I bet you’ll have better luck in the matrix room or qubes-devel mailing list with this question.

It’s a good idea to be there if you plan to make a pull request, just to have a tap into current developements.

1 Like
3

Thanks for the reply!

Yeah, I didn’t do it in the first place because I didn’t wanted to disturb with a “minor” topic. But I’ll do that then.

Have a nice day!