Qubes OS R4.3-alpha Preview

alimirjamali · September 13, 2024, 9:22am

Regretfully it appears that this is not working. See the screenshot below

barto · September 13, 2024, 9:25am

Ugh. It’s been dropped, seemingly, and only the configuration item is available:
https://dnf5.readthedocs.io/en/latest/changes.html#changes-to-individual-options

alimirjamali · September 14, 2024, 7:37pm

Ok. Back to the above. This could be done by adding a new option to qrexec-client to filter out the whole ANSI escape sequences. Or maybe the existing -t & -T options should do it. The existing do_replace_chars of libqrexec only replaces few chars with underline.

Another approach would be doing this at qvm-run level in Python. There are easy to use Regex workarounds.

alimirjamali · September 14, 2024, 11:07pm

Another bug which is most probably DNF5 related. qvm-template and qubes-template-manager (GUI) are broken with Fedora 41 based UpdateVMs:

Could be related to order of arguments passed to qvm-template-repo-query script. Or how DNF5 formats the output.

marmarek · September 15, 2024, 1:26pm

--setopt=color=never?

alimirjamali · September 15, 2024, 2:22pm

Regretfully no:

fjdh · September 15, 2024, 4:12pm

bug that exists in 4.2 and 4.3: if you have configured custom colors, you cannot restore the VMs until you create a custom color with the same name on the new system, and there is no way to select ‘ignore missing colors’ like you can with dom0 user mismatch etc.

alimirjamali · September 15, 2024, 4:27pm

Turns out to be the DNF5 output mismatch:

They broke backward compatibility for %{reponame} and %{buildtime} used here:

github.com

QubesOS/qubes-core-agent-linux/blob/main/qubes-rpc/qvm-template-repo-query#L52


      
          # unchanged otherwise.
          # We then copy the {c,m}time to the repo config.
          # This allows DNF caching to work properly.
          hashfile="/tmp/qvm-template-$(b2sum "$repodir/template.repo" | cut -f1 -d' ')"
          touch -a "$hashfile"
          touch -r "$hashfile" "$repodir/template.repo"
          
          RET=0
          
          if [ "$1" = "query" ]; then
              dnf repoquery "${OPTS[@]}" --qf='%{name}|%{epoch}|%{version}|%{release}|%{reponame}|%{downloadsize}|%{buildtime}|%{license}|%{url}|%{summary}|%{description}|' "$SPEC"
              RET="$?"
          elif [ "$1" = "download" ]; then
              # Download/retry algorithm: take mirrors in random order. In this order,
              # try to download from the first one - if download failed but anything was
              # downloaded - retry from the same one. If download failed and nothing was
              # downloaded, go to the next one. The intention is to retry on interrupted
              # connection, but skip mirrors that are not synchronized yet.
              urls="$(dnf downloadurl "${OPTS[@]}" --url --all-mirrors "$SPEC" | shuf)"
              readarray -t urls <<<"$urls"
              downloaded=0

Also DNF4 prints an extra line after repoquery (which the code expects) whereas DNF5 does not. Overall it is easy to fix.

alimirjamali · September 15, 2024, 4:29pm

I believe restore mechanism should be fixed to revert to Red Label on missing colors. And Red Label should be made a red line (The label that is not allowed to be deleted)

alimirjamali · September 16, 2024, 4:40pm

I submitted the patch to support DNF5 based UpdateVMs with qvm-template. The existing unittest for qvm-template is a freakin’ 5643 line (236KB) file. If anyone is interested on working with unittests, there is room to consolidate some of tests together.

alimirjamali · October 2, 2024, 3:49pm

I submitted a patch to DNF5 to reintroduce the --color option. It appears that they wanted to re-implement it but did not have time. Awaiting review.

p.s.: Contrary to what the DNF5 change notes mentions, the configuration is also ineffective at the moment.