Lenovo G505s

Hi there @dispuser5132 and @Raphael_Balthazar , just found this thread! :wink: Thank you for sharing your experiences, I am sorry to hear about your problems 1 year ago:

Seemed that we both followed the recommended build guides from Mike Banon on DangerousPrototypes. When i was building with his patches my build failed.

Have you reported this problem to my [ mikebdp2 [at] gmail [d0t] c0m ] e-mail mentioned at my DP guide? IMHO my guide+script are quite refined, and when they do not work - despite you did everything right and your build environment is OK - a true cause of breakage is some new commit at the coreboot repository.

For an example, take a look at this small commit. This tiny change may look innocent, however it made a coreboot’s ./g505s/irq_tables.c incompatible with my AMD good IRQs patch, causing

...
patching file src/mainboard/lenovo/g505s/irq_tables.c
Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED -- saving rejects to file src/mainboard/lenovo/g505s/irq_tables.c.rej
...

And, since I’m not rebuilding my BIOSes all the time and have the other things to do, this problem stayed for two weeks until a user reported it to me! As a temporary solution I told him to do a git revert for this particular commit and updated my custom patches to restore the compatibility.

Another problem, which happened around 1 year ago (so may have been a cause of your troubles) : a coreboot’s GCC got upgraded to 11.x version, but for unknown-yet-reasons it builds the unstable ROMs for our AMD AGESA boards including G505S. The only known solution is to additionally do

git revert ce134ababd6a444082962ccdfcd34415a647f41e
[press Ctrl+X then Y if your default git editor is nano, to apply this]
git revert b0d87f753c9c517ba906115362d32aa4422fd188
[press Ctrl+X then Y if your default git editor is nano, to apply this]

to downgrade a coreboot toolchain’s GCC to old trusty 8.3.0 version, before building this toolchain with make crossgcc-i386 . Of course this info is a part of a guide already.

I can assure you that, if you’ll try my guide right now, it should be working flawlessly! At least it worked 3 days ago when I rebuilt my BIOS, and it’s unlikely the compatibility has been lost so fast: i.e. last time it lasted 5 months (until the things got broken for 2 weeks because of a minor commit which I mentioned above)

2 Likes